Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Jetpack: post experiment clean up #39928

Merged
merged 3 commits into from
Oct 29, 2024
Merged

My Jetpack: post experiment clean up #39928

merged 3 commits into from
Oct 29, 2024

Conversation

IanRamosC
Copy link
Contributor

@IanRamosC IanRamosC commented Oct 28, 2024 •
edited
Loading

Proposed changes:

  • This PR just removes the code related to the experiment we were running this month (22033-explat-experiment).
  • Note: in terms of experience, this shouldn't affect much to the general user. So just test to make sure the connection process in My Jetpack is working correctly.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Spin up a JN site with Jetpack Beta pointing to this branch
  • Go to My Jetpack and click to "Activate Jetpack with one click"
  • Confirm that everything works as expected

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/my-jetpack-ab-test-cleanup branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack remove/my-jetpack-ab-test-cleanup

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@IanRamosC IanRamosC marked this pull request as ready for review October 28, 2024 14:40
robertsreberski
robertsreberski previously requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@robertsreberski robertsreberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the code, it is a very thorough clean up!

I think just one detail left, that I commented below, otherwise it will be good!

projects/packages/my-jetpack/_inc/components/welcome-flow/index.tsx Outdated
Comment on lines 60 to 61
if (
'treatment' === welcomeFlowExperiment.variation &&
! recommendedModules &&
isJetpackUserNew()
) {

if ( ! recommendedModules && isJetpackUserNew() ) {
return 'evaluation-processing';
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case, we need to remove the condition altogether, as it was only applicable for 'treatment'.

Currently, the flow gets stuck on the processing step, as I'm testing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this piece of code in the other PR, but I'll remove it here as well since it affects the behavior of the connection.

CodeyGuyDylan
CodeyGuyDylan approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IanRamosC IanRamosC merged commit cd1dedf into trunk Oct 29, 2024
71 of 72 checks passed
@IanRamosC IanRamosC deleted the remove/my-jetpack-ab-test-cleanup branch October 29, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeyGuyDylan CodeyGuyDylan CodeyGuyDylan approved these changes

@robertsreberski robertsreberski robertsreberski left review comments

Assignees
No one assigned
Labels
[Package] My Jetpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanRamosC @robertsreberski @CodeyGuyDylan